Isuru Fernando

Results 928 comments of Isuru Fernando

Can you add some tests?

Can you resolve conflicts and add tests for parser errors?

@rajithv, do you have time to finish this PR? If not, can you enable edits from maintainers?

@mohawkjohn, can you reinstall with this line uncommented https://github.com/symengine/symengine.rb/blob/master/cmake/FindRuby.cmake#L54 and then post the build log?

I tried with `rbenv` and it fails at link time (not load time like @mohawkjohn) because ruby was not built with PIC. ``` Linking C shared library ../../lib/symengine/symengine.so /usr/bin/ld: /home/isuru/.rbenv/versions/2.3.0/lib/libruby-static.a(array.o):...

I just did, and it fails to install json 1.8.3. json needs to be updated to 2.0.1 to build with the latest ruby version. So, I guess this is an...

Problem is that with ruby 2.4.0-dev, this is checked strictly. Earlier when ruby 2.0.1 was installed it was okay even if rdoc needed < 2.0. Now it is enforced and...

Yes, it is. Dropping the json requirement won't help, since rdoc has json as a requirement.

Dropping the requirement will help ruby versions < 2.4

Isn't this a feature that the envs for outputs are not activated by default and `activate_in_script: True` has to be added explicitly to make it so?