symengine.rb icon indicating copy to clipboard operation
symengine.rb copied to clipboard

Ruby wrapper for parser

Open rajithv opened this issue 9 years ago • 9 comments

rajithv avatar Jul 08 '16 14:07 rajithv

Can you add some tests?

isuruf avatar Jul 08 '16 14:07 isuruf

@isuruf can we merge this now, that the https://github.com/symengine/symengine/pull/1044 has ParseError, so exception catching regarding Parser can be done in https://github.com/symengine/symengine.rb/pull/63 with other exceptions?

rajithv avatar Jul 31 '16 10:07 rajithv

Can you resolve conflicts and add tests for parser errors?

isuruf avatar Aug 21 '16 03:08 isuruf

@isuruf @abinashmeher999 please review.

rajithv avatar Aug 22 '16 15:08 rajithv

@certik @abinashmeher999 @isuruf should I make another PR to continue this work after the GSoC period? Because the submission guidelines asked not to change the submitted material after submission. Pls advice on this.

rajithv avatar Aug 24 '16 04:08 rajithv

I assume the submission guidelines mention about putting in the exact amount of work that was achieved during the GSoC period. That you have mentioned in the blog post already. As long as you are not changing the contents and the amount of work achieved, you won't be violating any rules. Correct me If I am wrong.

You can keep the new exception making part for another PR. I think we can go ahead with merging this. Just a few more changes that have been suggested and we will be good to go.

abinashmeher999 avatar Aug 24 '16 08:08 abinashmeher999

@rajithv, do you have time to finish this PR? If not, can you enable edits from maintainers?

isuruf avatar Oct 08 '16 09:10 isuruf

@rajithv ping.

certik avatar Oct 11 '16 18:10 certik

@isuruf @certik I will find sometime to complete this PR

rajithv avatar Oct 12 '16 16:10 rajithv