nmatrix icon indicating copy to clipboard operation
nmatrix copied to clipboard

rdoc and json are incompatible

Open isuruf opened this issue 8 years ago • 8 comments

rdoc needs json ~> 1.4 (>=1.4, < 2.0) and nmatrix requires >= 2.0.1.

isuruf avatar Oct 20 '16 14:10 isuruf

I believe I just put in ~> 2.0.1 because that's the one I got working at the time. Do you want to see what happens in your PR if you change it to 1.4?

translunar avatar Oct 20 '16 14:10 translunar

I just did, and it fails to install json 1.8.3. json needs to be updated to 2.0.1 to build with the latest ruby version. So, I guess this is an issue with rdoc

isuruf avatar Oct 20 '16 14:10 isuruf

Problem is that with ruby 2.4.0-dev, this is checked strictly. Earlier when ruby 2.0.1 was installed it was okay even if rdoc needed < 2.0. Now it is enforced and therefore fails.

isuruf avatar Oct 20 '16 14:10 isuruf

Is this the problem?

https://github.com/flori/json/issues/303

It looks like we can just drop the json requirement altogether, yes?

translunar avatar Oct 20 '16 14:10 translunar

Yes, it is. Dropping the json requirement won't help, since rdoc has json as a requirement.

isuruf avatar Oct 20 '16 15:10 isuruf

Dropping the requirement will help ruby versions < 2.4

isuruf avatar Oct 20 '16 15:10 isuruf

Looks like we need RDoc 5.

https://github.com/rdoc/rdoc/pull/412

translunar avatar Oct 20 '16 15:10 translunar

Possibly related to #606?

translunar avatar Dec 20 '17 17:12 translunar