Isuru Fernando

Results 928 comments of Isuru Fernando

Can't you use the jnlp slave image and run the `run_docker_build.sh` file? It removes duplicating of scripts

Agree with @jakirkham and @marcelotrevisani. `license_family` is unneeded when we have `license`. (To make `license` entry SPDX compliant, we have https://github.com/conda-forge/conda-smithy/pull/1220)

Any solution based on `git config --global core.autocrlf false` is not going to work as some contributors just upload using github UI which doesn't care about line ending settings.

PRs are welcome. Note that the README still uses the conda-forge.yml so that should be fixed as well.

If `CMAKE_GENERATOR` is used, it will be a used variable. It's not necessary to use `always_keep_keys`

I don't think there's anything we have to do. If the package supports GPU builds, they can use the metal compiler to compile the GPU code.

> Not sure I understand - "they" is the users? No, the maintainer of the package. > I get that this would mean that there'd have to be a cf-compatible...

Nope. Metal is very macOS specific and I haven't seen packages supporting metal except games.

I don't understand what you are trying to do here. Have you seen any package with Metal support that we package without Metal?