Open3D icon indicating copy to clipboard operation
Open3D copied to clipboard

Enable pickling for tensor and tensor based geometry

Open yuecideng opened this issue 3 years ago • 3 comments

This PR makes Tensor, TensorMap and tensor based geometry pickling.

Current behaviours:

  • Tensor will be on the same device after de-serialization.
  • Non contiguous tensor will be converted to contiguous tensor after de-serilization.

This change is Reviewable

yuecideng avatar Sep 07 '22 02:09 yuecideng

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

update-docs[bot] avatar Sep 07 '22 02:09 update-docs[bot]

LGTM after adding python unit tests.

yxlao avatar Sep 08 '22 00:09 yxlao

  • Add python unit tests for pickling support.
  • Minor change PointCloud::ToString() output to be consistent with TriangleMesh:
PointCloud on CPU:0 [2 points (Float32)].
Attributes: normals (dtype = Float32, shape = {2, 3}).

@yxlao

yuecideng avatar Sep 08 '22 03:09 yuecideng

Great work. It would be very helpful to add a brief documentation example on the Tensor page. TODO: Check newly added features that are missing documentation and make a priority-based checklist for the same.

reyanshsolis avatar Sep 27 '22 14:09 reyanshsolis

It would be very helpful to add a brief documentation example on the Tensor page

Sounds good, I will add it later.

yuecideng avatar Sep 28 '22 01:09 yuecideng