Ian Kerins

Results 69 comments of Ian Kerins

Hi @ozelalisen, I see you assigned yourself a while ago. I would be grateful for a review.

@ozelalisen I think I've addressed everything, please take another look.

Maybe I'm misinterpreting the comment, and the current behavior is intentional, but it'd be strange that absolute paths in disk `path` don't work the same way that absolute paths do...

Thanks for the reply. What you said all makes sense. I did not consider the case of `workerd compile`. In that case it is not clear what “disk directory relative...

@kichik how would you plan to handle the `cdkghr:started:` labels with --jitconfig? Seeing as the actual start time baked into those labels has to be _even more jit_ 🌞 than...

@wbpcode we are affected by this regression in omit_empty_values. We ship access logs from Envoy to a SaaS log service that charges by the byte - uncompressed. So we do...

We have a bunch of optional fields in our access logs set dynamically using certain request headers or metadata. The data is fairly sparse. I don’t think we’ve got any...

Makes sense. Thank you for trying. We use Fluent Bit to collect and transmit Envoy logs and are filtering out empty-valued properties there. It involved writing a hacky Lua filter...

As far as I can tell this issue has not been addressed.

> @isker could you provide more details for the expected behaivor on this isse? No. I do not use this software any longer. Sorry.