Ian Kerins
Ian Kerins
Hi @mcollina or @jasnell, could you take another look at landing this? I'm not sure whether the orange stuff in Jenkins means CI failed or not.
Thanks @jasnell!
I don't have any plans to attempt a backport myself.
@alvazjor why did `main` get force pushed here? Every PR now has many conflicts that are challenging to resolve :(.
> Thank you for your work! I've added some minor comments. Thank you very much for reviewing. > Is there a reason for combining the two features - VPC and...
I have rebased and am rerunning the new integration tests in this PR, as main has changed the snapshots. It takes a really long time to run integration tests that...
😕 the main build succeeds but I don't understand either of the other jobs that failed. Especially the security guardian one, seems all unrelated to my changes.
@badmintoncryer do you know how to get the label added now that #35268 is fixed?
Still no label 🥲.
> it seems it has not been fixed yet. @badmintoncryer is there an open issue for this?