Ian Kerins
Ian Kerins
I ran tasks with both ecs_exporter and an `alpine` sidecar running `["/bin/sh", "-c", "yes > /dev/null"]` (i.e. chewing up a lot of CPU) on Fargate and EC2. They both had...
> Fortunately there is a hierarchical_memory_limit which should give us what we want and it should be easy to add this to the exporter. I can confirm this is correct....
Here's a TODO explaining just this: https://github.com/cloudflare/workerd/blob/249464fcec85ef47c8328aa4ae93042fdc5906c5/src/workerd/server/server.c%2B%2B#L435-L436
You added the TODO two years ago in https://github.com/cloudflare/workerd/commit/dc27ddcb80f29a2da23ad370f138a2b5b21ae585. So it doesn’t seem to be a bug as much as consciously acknowledged missing functionality. And I don’t think that commit...
@RedYetiDev can you take another look?
@nodejs/fs please take a look. Thanks!
Maybe someone from @nodejs/streams could review?
Thanks @jasnell. @avivkeller stated on slack that they don't think they're qualified to approve but I don't know how to withdraw the review request here. Besides that, I think there...
Hi @jasnell, is there anything else I need to do to land this PR?