Isaac Miller

Results 48 comments of Isaac Miller

Also is there any way to add tests for this?

> I have a unittest created. Where?

There is a duplicate PR with #682. I have no personal preference for either one, and it seems like yours is aimed with more modalities in mind. Tagging @KCaverly @CyrusOfEden...

Yes unmerging would unblock this

Also how do you feel about the pre-commit checks? A lot of the code isn't up to style, and it seems very strict. But this could be the start of...

Leaving databricks commented out but can also delete files

Yeah weird i already manually added pydantic to the .toml file

Ready to merge whenever @okhat We do have 3 different build systems currently and should probably get rid of 2 of them, but that can be further discussion

Wait don't merge setup.py is broken now

Ok we good now, setup.py build works