dspy
dspy copied to clipboard
ci(dspy): Add tests to CI
- Create a new action to run the tests that @thomasahle implemented. Fix #456
- Fix the pre-commit checks workflow
- Adjusted the pyproject.toml to have pytest as a dependency.
Note: databricks integration does not pass tests. Commented out as that is the only integration to do so. To be added back at a later date
The databricks integration is very new so it doesn’t have users yet (merged today). Is unmerging it temporarily useful for this
Yes unmerging would unblock this
Also how do you feel about the pre-commit checks? A lot of the code isn't up to style, and it seems very strict. But this could be the start of actually requiring people's code to meet the style guide
Imo let’s not worry about style checks just yet
And 100% feel free to temporarily remove the databricks integration if you like. We’ll add it back soon
I’d like to merge this when you think it’s ready! No rush though
Leaving databricks commented out but can also delete files
Oh looks like import pydantic is failing here. Btw so far I've been relying on setup.py so it's very possible the *.toml is not completely correct, someone created it a while back and it may have some mistakes
Yeah weird i already manually added pydantic to the .toml file
Ready to merge whenever @okhat
We do have 3 different build systems currently and should probably get rid of 2 of them, but that can be further discussion
Wait don't merge setup.py is broken now
Ok we good now, setup.py build works
@isaacbmiller , this is great. I did not go through databrick file since it is commented out, but others looks good to me.
@okhat I am locking pydantic dependency to 2.5.0 because there is a test that specifically relies on the version of pydantic. I would rather merge this than rewrite that test, so I will rewrite the test later
Hmmm github not adding in recent commits
Ready to merge
@okhat Can I merge?
Hi @isaacbmiller , I just patched the databricks.py file in this latest PR to move the OpenAI dependency within a local function. feel free to check it out if that passes the tests now so we can merge that alongside this PR!
Thanks @isaacbmiller ! ready to merge on @okhat 's go :)
Ok running some checks!
Unclear why the first test is failing... I tinkered with poetry but it didn't help