irwir

Scope of enabled compiler warnings

1

https://github.com/weidai11/cryptopp/blob/631b7082c33d3cb4246eb4ccb7545f2afd8e2446/config_misc.h#L170-L171 The linked article is quite good, and suggestions are useful. Though MS itself refuses to make their own library code thouroughly cleaned up, and there are other blogs with...

Return to using a named constant

2

The commit [ Use WINVER values instead of _WIN32_WINNT_[NAME]. ](https://github.com/miniupnp/miniupnp/commit/c1b64740fb8867ceee67a5ea4c0e8d696d5b22da) goes against common practice of avoiding numerical constants. It might be better to add conditional directives into one of the...

Building static library in VIsual Studio 2017

2

**develop** branch. The solution from `vc14` was successfully upgraded, but static library could not be built for `x86` and `x64` platforms. The diagnostics depended on the selected configuration/platform: > c1...

Duplicate line in pngrutil.c

1

An extra line (probably a copy-paste error), that existed for years but was not spotted because it breaks nothing. https://github.com/glennrp/libpng/blob/301f7a14295a3bdfaf406dbb5004d0784dc137ea/pngrutil.c#L304-L305

Check for error might have been needed

1

Comparing two code blocks, starting here https://github.com/madler/zlib/blob/b8a8373ec195c8d286fe7e81e78b4a6d31bd859f/contrib/minizip/zip.c#L1414 and here https://github.com/madler/zlib/blob/b8a8373ec195c8d286fe7e81e78b4a6d31bd859f/contrib/minizip/zip.c#L1484 In the first case `err` was assigned and checked after the conditional statement. In the second case it was ignored...

Using emplace_* instead of push_*

4

`emplace_*` methods are more efficient when adding new objects, but might require C++11. Does it make sense to add code for this? Tests run successfully for the branch https://github.com/irwir/cryptopp/tree/use_emplace

VS2022 with the current head > cryptopp-master\validat2.cpp(1177,69): warning C4244: 'argument': conversion from 'CryptoPP::word' to 'long', possible loss of data Should `m` be declared as `Integer`?

Enumeration type for SSL 'state' variable

1

https://github.com/Mbed-TLS/mbedtls/blob/b90e695e09363915961b62c93c69479254137769/include/mbedtls/ssl.h#L1631 Probably this would be better as ` mbedtls_ssl_states MBEDTLS_PRIVATE(state); /*!< SSL handshake: current state */ `

Handshake failure due to ticket arrival

2

### Summary Testing `sls_mail_client.c` with locally installed `hMailServer` (based on OpenSSL library). Server cannot be connected due to handshake failure. ### System information Mbed TLS version 3.5.0 Operating system and...

vboxguest.inf not detected as old drivers

2

There were about 20 lines `vboxguest.inf` in a Virtualbox guest OS (Windows 11 Insider). None were checkmarked after pressing `Select Old Driver(s)` button, but successfully purged after manual selection.