irwir

Additionally, warning numbers might be VS version-specific. For example, in VS 2019 the line `# pragma warning(disable: 4231 4275 4700)` causes generation of warning C4619: there is no warning 4231.

@miniupnp, you are right. I amended the issue text above.

jbowler, thanks for your remarks. The macro _is_ unsafe. Normally these warnings should be silenced. Expecting a compilation error in case of misuse is a poor protection. For example, a...

> Silencing a warning by changing the semantics of the code is not correct. @jbowler, please care to explain how semantics was easily changed with an additional pair of parentheses.

@jbowler The first two words in the description of this PR are `Static analisys`, and the title has the word `fix`. Once again: `fix`, not `silence`. This kind of warning...

By the way, this tiny issue was promised to be fixed in the #216 - closed only partially completed.

Thanks for reviewing. I changed the code and the description in the first message.

As could be read, at least one more version of 1.6 was planned. So this code might stay for some time, while 1.7 branch did not pan out. PS. About...

Multibyte is obsolete, Unicode is the right way to go.

> Unicode is multi-byte. Unicode encoded as UTF-8 is variable length multi-byte at that. This is mostly correct, yet shows zero experience with Visual Studio and Windows. `Use Unicode Character...