irwir

Results 148 comments of irwir

This PR goes against portability, because any non-listed compiler would require source code changes.

> Regarding 2, ... > This is not something that can easily be enforced with tooling, so I’d say there’s limited room for improvement here. Is this really limited? Previous...

> This looks like a relatively simple fix - as you point out, we should be able to add `(void) ret;` to solve the issue. Such fix would be a...

> ( state * 1103515245 + 12345 ) This code (from an archived repository) shows horrible choice of parameters. With proper numbers the internal state makes full circle going through...

There is nothing to record without keyboard visualizer (could it modify input behaviour by changing focus briefly?). Created new score, double clicked on title, clicked on the font selector, pressed...

Same here for `i,` `o` and `p` keys. Quick typing trick suggests timing/synchonization dependence and this could be the reason why `r` does nothing special in your case. Probably, no...

> Change this so that we initialize the result to 0xFFFFFFFF (indicating failure) when we first initialize the session object. This solution could have been cleaner. First, it uses `magic...

int mbedtls_ssl_session_copy(mbedtls_ssl_session *dst, int mbedtls_ssl_add_hs_hdr_to_checksum(mbedtls_ssl_context *ssl, int mbedtls_ssl_add_hs_hdr_to_checksum(mbedtls_ssl_context *ssl, int mbedtls_ssl_add_hs_msg_to_checksum(mbedtls_ssl_context *ssl, int mbedtls_ssl_reset_checksum(mbedtls_ssl_context *ssl) int mbedtls_ssl_session_reset_int(mbedtls_ssl_context *ssl, int partial) int mbedtls_ssl_conf_has_static_psk(mbedtls_ssl_config const *conf) int mbedtls_ssl_start_renegotiation(mbedtls_ssl_context *ssl) int mbedtls_ssl_check_curve_tls_id(const mbedtls_ssl_context...

Probably it was this one: https://learn.microsoft.com/en-us/cpp/code-quality/c28252?view=msvc-170 Then code analysis should be enabled.

There was an odd and failed attempted fix; the issue survived and got bigger. Now there are many more functions with non-annotated definitions. Additional list of files might be incomplete,...