Ivan Ruiz Manuel
Ivan Ruiz Manuel
Solved by #783 Let us know if it ever resurfaces @jmorrisnrel
The other solution is to remove the internal default from the xarray variable (e.g., `model._model_data["distance"]` no longer shows the default). I'm not a fan of this one, because I see...
After some thinking, I believe every input parameter SHOULD have a default in `model._model_data`. If it does not, it means we have an issue in our preprocessing.
Heavily in favor of that. Although we do have defaults for most `model.inputs.data_vars` (we add them during init). In the national example the only ones missing this are: 1. 'base_tech'...
Agreed. Summary of fix: - Remove `model.default` attribute, add as a property as described above. - We should define which parameters are lookups somewhere. Lookups should have no default, so...
Wait... if we want to keep the defaults of unused parameters after init, then the best solution is the opposite: Just keep them in `attrs[defaults]`. You do not get the...
@brynpickering After considering #642, probably an even better solution is to have all this stuff in the new `CalliopeMath` class. It fits it perfectly, I feel. The only issues will...
Linking to #642 as this would essentially be closed once that is finished.
Solved by #783
We should make sure all of our base math has units or specifies them `units` should remain as an optional setting in the schema though.