calliope-project
No unit for `global_expressions` set, even if schema requires
What happened?
Just as variables do, global_expressions should state their unit. Among others, this makes life easier when post-processing results.
It seems like unit is required for both variables and global_expressions (https://github.com/calliope-project/calliope/blob/main/src/calliope/config/math_schema.yaml), but in base math, only the units of variables are specified.
Which operating systems have you used?
- [ ] macOS
- [ ] Windows
- [X] Linux
Version
v0.7.0
Relevant log output
No response
The schema doesn't require it, just provides the rules it must follow if it is defined. It's the same with "title" and "description". It's probably good practice for us to have them defined for all of our pre-defined math components, but I wouldn't require it for user-defined components since it's just metadata (the user can decide if they care to have it).
Thanks for clarifying! I agree, it is good practice. I can open a PR adding that metadata to our base math.
We should make sure all of our base math has units or specifies them
units should remain as an optional setting in the schema though.
