ionic-framework
ionic-framework copied to clipboard
chore(angular): use generated proxy declarations
Pull request checklist
Please check if your PR fulfills the following requirements:
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
- Some docs updates need to be made in the
ionic-docs
repo, in a separate PR. See the contributing guide for details.
- Some docs updates need to be made in the
- [x] Build (
npm run build
) was run locally and any changes were pushed - [x] Lint (
npm run lint
) has passed locally and any fixes were made for failures
Pull request type
Please check the type of change your PR introduces:
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [x] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
What is the current behavior?
The Angular package uses generated proxies (components). Currently, we are manually importing and adding these components to the declarations array for the module. Since this is a human process, it is prone to error and us forgetting to add the declaration.
Issue URL: N/A
What is the new behavior?
- Stencil compiler will build the "proxies array" (constant of all the declarations) when running the angular output target
- Angular package will use this constant for the declarations (no more manually maintaining automatic proxies)
- Fixed a miss spelling with the numeric value accessor (was "accesssor" in the file name)
Does this introduce a breaking change?
- [ ] Yes
- [x] No
Other information
This PR accomplishes the same result as #25727 + sets us up for the future. I do think we should treat them as separate PRs for visibility to the community + changelog.