Mateusz Gozdek

Things to consider: - Decide if `version` package should be exported. - Consider moving `version` code to `cmd` package. - Consider logging operator and agent version from operator code, rather...

For operator, following tests must still be added: - Test `New()` constructor ```go FAIL "/tmp/go-mutesting-068518235/pkg/operator/agent_manager.go.5" with checksum d1d55f49f782e9210654d61f82593b99 Mutate "pkg/operator/operator.go" --- pkg/operator/operator.go 2021-06-09 09:35:27.556903533 +0200 +++ /tmp/go-mutesting-068518235/pkg/operator/operator.go.0 2021-06-09 09:37:21.034736036 +0200...

Agent tests has been finally added in #116. We have left: - cmd tests for both operator and agent. - `pkg/version` (though this should likely be removed as part of...

Some done in #108.

#1 is now done, so this can be closed too? I see https://github.com/tinkerbell/sandbox/runs/1662739685?check_suite_focus=true being run. With that, v0.1.0 milestone can be closed as well.

Ah, my bad. We only have a Vagrant check. Sorry for the noise :)

Here is some simple [semgrep](https://semgrep.dev/) rules which I always use to catch things like that: ```yaml rules: - id: bad-error-wrap-wording patterns: - pattern-regex: fmt\.Errorf\(".?([Ff]ailed|[]Uu]nable|[Cc]ould|([Ee]rror)|([Cc]an[ ]?not)) message: Phrases "fail", "failed", "unable",...

Yeah, so top level, you get something like `Error occurred running inspector-gadget CLI: running exec tracer: creating tracer: no bla configured`, instead of `Error occurred running inspector-gadget CLI: failed to...

Just a note, when addressing the feedback in #2271, I've noticed that after making field a pointer type in `cmd/clusterawsadm/api/bootstrap/v1beta1/types.go`, autogenerated code for filling the default values for fields no...

/remove-lifecycle stale