Mateusz Gozdek

Results 421 comments of Mateusz Gozdek

Hi @tijmenvandenbrink! I'd say the status of this enhancement is _accepted_. I don't know when this will be implemented, but thank you for showing up your interest. It will be...

>Maybe there is also some inspiration at https://github.com/weaveworks/kured It seems they only expose single metric `kured_reboot_required`, but thanks! >Really cool will be some kind of "Blocking Reboots via Alerts" etc.....

@jiphex thanks for the contribution to the ecosystem, nice seeing community work around :) I've seen your project yesterday actually. Please keep in mind though, that existing updateengine package has...

Related to this work, it would also be cool to have a Grafana dashboard consuming those metrics. E.g. I have a dashboard like this right now: ![Selection_582](https://user-images.githubusercontent.com/16539896/175821329-f5485dc0-6d33-4d45-85b7-982bb90c8e53.png)

With #160, we're down to 8 issues: ```console $ git grep nolint | grep TODO | wc -l 8 ```

Actually, this does not affect agent, as it always drains the receive channel, but it's important to notice when consuming `pkg/updateengine` directly, so we should have unit tests for this.

This also happens when you close the client before stopping the receiver routine, so clearly a bug.

Not sure if 100% accurate, hence the comment and not the PR, but from what I understand from the code, flow looks like on the image below. Note, that some...

Slightly different version with highlighted stages I was able to identify: ![Selection_381](https://user-images.githubusercontent.com/16539896/113789059-b677c080-973e-11eb-93b8-9f2f05892133.png)

This PR will become relevant once we have enough test code for agent to add checking for reboot errors.