Mateusz Gozdek

Results 418 comments of Mateusz Gozdek

>I don't see an e2e test added to the test suite. See https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/test/e2e/azure_test.go#L268 for an example. Thanks. I've added test for Flatcar flavor and it's passing for me locally. I...

Flatcar e2e test fails because the community gallery is in the wrong location. I'll fix that next week.

/test pull-cluster-api-provider-azure-e2e-optional Replicated image to `eastus2`, let's see if test passes now :crossed_fingers:

e2e tests for Flatcar passed in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/1729/pull-cluster-api-provider-azure-e2e/1521131029673283584.

/hold Until community gallery references are updated to something more reasonable than my test community gallery. @CecileRobertMichon e2e tests for Flatcar are now passing using community gallery, so this PR...

In case community galleries support gets merged with this PR, we might also modify PR description before merging to mention it resolves https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/2267. I don't have permissions to do so.

>@invidian would it be easier/better to extract the community gallery support to a separate PR? If so, feel free to do so. Here the community gallery has e2e tests with...

I also got hit by this couple of times to the point my machine was very slow due to 10+ instances of api server and etcd running.