Gary Lockett
Gary Lockett
Thanks @ghostwriter
Everything checks out though. Looks good to merge if we decide to go down this route, but I'm not convinced its necessary.
As I understand it, that repository is for the typescript mappings for everything `@types/` related, including `@types/semver`. The implementation for the `semver` library would be https://github.com/npm/node-semver. I've opened an issue...
It appears there are [some other differences](https://github.com/semver/semver/pull/584#issuecomment-705503374), so I think we have to go this route after all.
@boesing FWIW I think regardless of the alias used it should be the same instance. Would it be feasible to resolve all aliased delegators to their service name prior to...
I was just using the interface for the example lib + app situation. But yes unalias the aliases, since they are resolved to the service name (the one that is...
+1 for this. Does it have to be delegator factories though (iirc these aren't the most performant)? If we're firing the bootstrap event from the Application factory, would there be...
Delegators vs regular factories, I was told around v2 time that they should be avoided where possible for performance reasons. Maybe I misunderstood/misremembered or thats no longer the case. Still...
> __construct is special: it's not considered by LSP rules :) 🤯
I believe this is something the Google library takes into account... Looking at an alternative implementation it works as expected: https://giggsey.com/libphonenumber/.