laminas-mvc-skeleton icon indicating copy to clipboard operation
laminas-mvc-skeleton copied to clipboard

Prepare for Renovate with reusable workflows

Open ghostwriter opened this issue 3 years ago • 3 comments

Q A
QA yes

Description

Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

  • Configure minimum supported PHP version
  • Update composer dependencies
  • Update to reusable Continuous Integration workflow
  • Update to reusable Automatic Releases workflow

ghostwriter avatar Feb 21 '22 03:02 ghostwriter

Skeleton app is an exception which needs to drop lock file entirely and switch to a scheduled testing.

Xerkus avatar Feb 22 '22 22:02 Xerkus

@Xerkus should I skip this PR?

ghostwriter avatar Feb 22 '22 22:02 ghostwriter

@ghostwriter No. Dependencies range in composer.json still need to be bumped to a version supported by the lower php bound

It was more of a reminder to @Ocramius comment that skeleton can not have lock file.

Xerkus avatar Feb 22 '22 22:02 Xerkus

There is nothing to run here. phpunit is not installed by default and existing test is rather a placeholder that also wants laminas/laminas-test as dependency.

laminas-test could be installed by installer prompt but real test needs to test the installer process itself to be of any use for the CI.

Xerkus avatar Aug 27 '22 10:08 Xerkus

There is nothing to run here. phpunit is not installed by default and existing test is rather a placeholder that also wants laminas/laminas-test as dependency.

I agree, as you previously mentioned, this is a skeleton repo, feel free to close this.

laminas-test could be installed by installer prompt but real test needs to test the installer process itself to be of any use for the CI.

yes, could be addressed in a separate pr.


by the way,xmllint failing, it may be a relative path issue. (unrelated to this pr)

ghostwriter avatar Aug 28 '22 03:08 ghostwriter

I don't think this can use the reusable workflow since all the tooling configuration is for use in a new project and not meant for checking this repository.

In fact, I think you could remove the file at .github/workflows/continuous-integration.yml and then merge this with a different title.

internalsystemerror avatar Sep 11 '22 17:09 internalsystemerror

I've updated the PR and Title to reflect our discussion.

ghostwriter avatar Sep 14 '22 22:09 ghostwriter

@Ocramius do you still want to target a new major with this?

internalsystemerror avatar Sep 15 '22 13:09 internalsystemerror

Skeleton isn't really affected by BC policy anyway :shrug:

Ocramius avatar Sep 15 '22 14:09 Ocramius

Thanks @ghostwriter

internalsystemerror avatar Sep 15 '22 16:09 internalsystemerror