laminas-ci-matrix-action icon indicating copy to clipboard operation
laminas-ci-matrix-action copied to clipboard

Published 20 hours ago • verified publisher icon laminas

Feature: Use `composer/semver` to detect PHP version ranges

Open boesing opened this issue 2 years ago • 4 comments

Q A
Bugfix yes
BC Break no
New Feature yes

Description

By using composers own composer/semver library, we are able to detect PHP version ranges from almost every composer-compatible constraint.

Fixes #87

boesing avatar Aug 10 '22 18:08 boesing

Everything checks out though. Looks good to merge if we decide to go down this route, but I'm not convinced its necessary.

internalsystemerror avatar Aug 11 '22 15:08 internalsystemerror

I've raised an "issue" in the NPM semver implementation: https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/61669

boesing avatar Aug 11 '22 20:08 boesing

As I understand it, that repository is for the typescript mappings for everything @types/ related, including @types/semver. The implementation for the semver library would be https://github.com/npm/node-semver. I've opened an issue for that one here https://github.com/npm/node-semver/issues/468. 🤞

internalsystemerror avatar Aug 11 '22 20:08 internalsystemerror

It appears there are some other differences, so I think we have to go this route after all.

internalsystemerror avatar Aug 12 '22 18:08 internalsystemerror