Jonas Eschenburg

Results 14 comments of Jonas Eschenburg

What I can imagine is to write a test against a mocked NOTIFY_SOCKET server, i.e. a mocked systemd. Concerning how to do it I think I need some guidance. I...

I have added a test (notify_socket_test.go). The question of how to deal with sd_notify_barrier timeouts is still open. `crun` waits for 30 seconds and then ignores the error ([see PR](https://github.com/containers/crun/pull/791))....

Thanks for clarifying, @kolyshkin! The two commits are now in the preferred order. Should we discuss how to handle the case where the supervising process doesn't (correctly) handle the `sd_notify_barrier`...

Committed the proposed solution (as a separate commit for your convenience, @kolyshkin). Wait 30s and warn but ignore on timeout. Just tell me and I'll merge the two commits into...

Here you go, @kolyshkin, and happy new year!

Hi @MofX, let me give my point of view. And sorry about it taking so long. First of all, whether this patch ends up in an official release or not...

@kolyshkin May I ask if there's a chance of including this in v1.1.2?

> @indyjo can you please rebase it (this will also re-run the CI on golang 1.18)? @kolyshkin Technically, it's done. There's a failing check though: `ci / centos-7`.

Thanks for bringing this up, @shuron77 ! What you would like to achieve, as far as I understand, is running a BitWrk worker on your computer but not sacrificing computing...