Indrek Juhkam

Results 23 comments of Indrek Juhkam

In case you're curious then this is how we're doing it: https://github.com/salemove/opentelemetry_function . Basically `task = Task.async(func)` turns into `task = Task.async(OpentelemetryFunction.wrap(func, "Some expensive calculation"))`. It can also be used...

The problem is that these spans are created by Ecto automatically deep inside the oban code. In ruby there's: ``` OpenTelemetry::Common::Utilities.untraced do # code end ``` which basically creates a...

+1, name sucks. It took me like a month to memorize it.

Tried this out in production (patched v1.1.2). Forwarded ~15% traffic to the patched instance. Given endpoint does 1-40 `get_by_key` calls depending on the input. Here are the results: First two...

@chrismccord any chance of getting this reviewed / merged as well?

I'm not sure if it's the same problem but my pools are getting stuck as well. I'm using hackney 1.15.0. Running get stats on the pool returns: ``` iex([email protected])14> :hackney_pool.get_stats(:"client-logger")...

// about opentracing-ruby Returning NOOP_INSTANCE may get especially confusing with https://github.com/opentracing/specification/blob/master/rfc/trace_identifiers.md#specification-changes . E.g. a logging library may include something like ```ruby if tracer.active_span log_metadata[:trace_id] = tracer.active_span.context.trace_id end ``` which doesn't...

Maybe not directly related to this PR but anyway: The doc explains the behavior of Scope / ScopeManager, but I feel like it's missing the `why`: Why is scope /...