Yosevu Kilonzo

Results 41 comments of Yosevu Kilonzo

Hi @pfulton and @Westbrook, it looks like the changes that need to be made are to the variants on the documentation site. Should I work on updating these? - Remove...

> @yosevu Mind taking a look at this one? The difference looks to be expected @pfulton since margin-inline-end, is 2px smaller using the updated design/tokens: https://github.com/adobe/spectrum-tokens/blob/beta/src/layout.json#L391

Should I be looking at the documentation site link at all? It doesn't look like it has the latest variants. For example, I removed disabled and the example color variants...

This is ready for review @pfulton @Westbrook!

Can I include swatchgroup 2.0.0-beta.0 https://github.com/adobe/spectrum-css/pull/1505 in this PR @pfulton @Westbrook? I don't see a separate package for it.

> This looks great, @yosevu. Well done. > > One request: can you please add Migration Guide documentation for each of the components affected by this change? We probably want...

This might be an issue on main since it doesn't appear to be relevant to this work. Capturing the screenshot until I find the source of the issue: Also, is...

Is it worth considering other spacing options to justify content when there are only two items so that there isn't such a large gap?

I noticed there isn't a border around the menu or submenu and I don't see tokens in the designs, but it seems like they would give a more realistic context...

I think a lot of my questions so far are scope related, so I will list them here: - Are switch and multiple selection options in scope for this work?...