spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

refactor(swatch): use core tokens

Open yosevu opened this issue 3 years ago • 4 comments

Description

Related issue(s)

Motivation and context

How has this been tested?

  • [ ] Test case 1
    1. Go here
    2. Do this
  • [ ] Test case 2
    1. Go here
    2. Do this

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • [ ] I have signed the Adobe Open Source CLA.
  • [ ] My code follows the code style of this project.
  • [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

yosevu avatar Sep 08 '22 20:09 yosevu

Can I include swatchgroup 2.0.0-beta.0 https://github.com/adobe/spectrum-css/pull/1505 in this PR @pfulton @Westbrook? I don't see a separate package for it.

yosevu avatar Sep 12 '22 15:09 yosevu

Yep, that'll be great. We merge them back together in our projects, so this is the right place!

Westbrook avatar Sep 12 '22 15:09 Westbrook

Tachometer results

Chrome

swatch permalink

Version Bytes Avg Time vs remote vs branch
npm latest 280 kB 31.77ms - 31.93ms - faster ✔
0% - 2%
0.14ms - 0.50ms
branch 282 kB 32.00ms - 32.33ms slower ❌
0% - 2%
0.14ms - 0.50ms
-
Firefox

swatch permalink

Version Bytes Avg Time vs remote vs branch
npm latest 280 kB 111.78ms - 122.70ms - unsure 🔍
-3% - +10%
-3.59ms - +11.35ms
branch 282 kB 108.26ms - 118.46ms unsure 🔍
-10% - +3%
-11.35ms - +3.59ms
-

github-actions[bot] avatar Sep 13 '22 20:09 github-actions[bot]