spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

Published 20 hours ago • verified publisher icon adobe

refactor: remove PickerButton and InfieldButton loudness levels

Open yosevu opened this issue 3 years ago • 1 comments

Description

These changes impact 4 components: PickerButton, InfieldButotn, Combobox, DatePicker

CSS-234

References

CSS-228 CSS-234 Slack thread

image

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

Screen Shot 2022-10-20 at 10 02 03 PM Screen Shot 2022-10-20 at 10 08 31 PM Screen Shot 2022-10-20 at 10 08 02 PM Screen Shot 2022-10-20 at 10 07 02 PM

To-do list

  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [ ] If my change impacts documentation, I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have tested these changes in Windows High Contrast mode.
  • [ ] This pull request is ready to merge.

yosevu avatar Oct 18 '22 02:10 yosevu

🚀 Deployed on https://pr-1531--spectrum-css.netlify.app

github-actions[bot] avatar Oct 18 '22 03:10 github-actions[bot]

Pulling in @Westbrook to be sure that he's aware of the things that will be changing here.

pfulton avatar Oct 20 '22 13:10 pfulton

This looks great, @yosevu. Well done.

One request: can you please add Migration Guide documentation for each of the components affected by this change? We probably want to say what's changing and how folks can switch to what's new. I'd write this from the perspective of if you were a developer who consumed these components and needed to know what changed.

We've done similar migration docs in ActionButton, if you want to use that as a guide: https://opensource.adobe.com/spectrum-css/actionbutton.html#migrationguide

Will do.

Updated @pfulton.

yosevu avatar Oct 20 '22 19:10 yosevu