Ben Abelshausen

icon company @anyways-open icon location Belgium icon location Works on @itinero @anyways-open @osmbe @OsmSharp and @bikedataproject

Results 167 comments of Ben Abelshausen

Debounce `fetchDirections` to prevent firing handlers while dragging markers

Thanks for having a look! I'll try and figure out why the check is not working but I'm not sure if I will be able to fix this myself in...

Take into account the 180/-180 in FilterBox()

I don't like the bounds class, it defines MinLongitude but that doesn't mean anything because you could define a bbox where the left longitude > right longitude wrapping around 180....

Message=Method not found: 'ProtoBuf.Meta.RuntimeTypeModel ProtoBuf.Meta.TypeModel.Create()

The latest protobuf version OsmSharp supports is 2.x so upgrading to 3.x is not going to work.

Complete Stream leads to data loss

Can you reproduce this still? For example in a unittest?

Add OSM ids and tags to generated features.

This is an interesting question. I'll see if there is some option to add some information to the resulting polygons that refers to the original OSM objects.

Improve OSM PBF read performance.

Thanks for testing this out. Performance hasn't been a major focus for OsmSharp for a while but with all the new features now available to use in .NET core there...

Improve OSM PBF read performance.

I was thinking about instead of using Current() to return an OsmGeo object we use properties on the OsmStreamSource class exposing the data (ID, changeset, user, nodes, members) OR (and...

Improve OSM PBF read performance.

Another option is to use an internal property that exposes an internal mutable object. It would also be a good idea to refactor the nodes and members array into something...

Improve OSM PBF read performance.

Multicore support? I hadn't considered that yet but it could be an option to read pbf data into a cache and use that to enumerate the OSM objects.

Improve OSM PBF read performance.

Some more info on this, I looked into this, the main effort is in reading the PBF blocks (obviously). From what I can see about how protobuf-net works, our only...