Will Lachance

Results 89 comments of Will Lachance
trafficstars

Hmm, interesting! Based on CI, it seems rather inconclusive whether this improves things -- the "load pandas" benchmarks improved on Firefox (and got worse on Chrome) but not outside what...

> Since we don't test the mac build, it might be hard for us to ensure that all uses of sed continue to be compatible with mac sed strangeness. It...

I think I've fixed this problem in a fork, but might be best to wait to see if upstream (which is also a fork) accepts my PR before doing anything...

I would personally recommend making the download work if possible -- updating pyodide packages is a manual process (just like this one) and requires review which can be somewhat slow.

> Let's see what other reviewers think about this. Maybe @wlach ? Hey, I don't think I have time to evaluate this in detail right now but in principle this...

~~(there's something wrong here, it doesn't fix the problem reliably -- back to the drawing board)~~

Ok on further testing I think this does actually work as expected (I had some difficulty setting up a good test environment). Open the following in a chrome private tab:...

Further refined this to handle the case where a CSS element was already loaded (which would result in the promise never resolving). I believe this might be related to this...

> This would need to be rebased, but is there a reason you don't just use SvelteKit instead? I don't really want to spend time on these edge cases for...

Poked around a little bit, it looks like there is some stuff inside mdsvex which currently is hardcoded to use `fs`: https://github.com/pngwn/MDsveX/blob/cb442cab61005f454c2e724226dea30a825dd982/packages/mdsvex/src/index.ts#L153 ... however I think that might be taken...