Will Lachance

Results 89 comments of Will Lachance

This is old, but AFAIK it's still a real issue and would be nice to fix. The solution is correct from what I can tell.

This seems preferable to my solution in #11942, just tested and it has the same results while making the search index smaller. :+1: from me.

> Hmm, the type-linting error highlighted by that adjustment is not entirely trivial; it bubbles up to the `BuildEnvironment` class. I'll fix it, but I seem to remember that environment...

> Mm, yep - the type hints themselves shouldn't affect anything... but they are an indicator that something about the possible range of values for their attributes has changed (`None`...

> > I'm struggling a bit to see the problem: aside from deserialization, I can't imagine for what reason we'd be reading index entries from Python code? I skimmed through...

@jayaddison Is there anything left to be done here or is this ready for a review by a committer?

@movermeyer Any chance this could be looked at? It seems straightforward and would really be helpful in a lot of use cases. Even where it's technically possible to rebuild the...

> Thanks for flagging this, @wlach. We'll take a look. Please open a pull request fixing it if you're so inclined. I put up a preliminary PR here: https://github.com/DataDog/dd-trace-py/pull/8657

Tested this out and verified that I got a trace for `psycopg`-style code when using aiopg (version 1.4.0). I will confess I am *not* an expert on datadog or its...

I think this is ready for a preliminary review. Please see comments for questions.