Will Lachance

Results 89 comments of Will Lachance

Apologies for my flailing around. Dug into things more and realized that @jasonlyu123 [was correct all along](https://github.com/sveltejs/language-tools/issues/1094#issuecomment-879506243): the injection rules are not being applied in an embedded context. The weird...

Based on the response in https://github.com/microsoft/vscode-textmate/issues/152, it looks like we might have to rewrite this not to use injection grammars (at least if we care about fixing this bug).

> Although I should add that one alternative is to use a different grammar for markdown, I think one that always uses TypeScript would be a decent compromise. Obviously that...

> Uh oh, this is a very large PR. 😦 > > Can it be broken up into smaller pieces that each individually work by themselves (aka not break things)?...

> @wlach thanks for a finding could you please submit PR with a fix? Will see what I can do.

Found an additional gotcha (`schedule` for `queries` can get set to the string `"null"` on downgrade), updated description.

Yeah, it's a bit unfortunate -- I assume the alembic db migrations were automatically generated, and were just wrong in this case. I think we need to verify (via `pg_dump`...

> > @wlach thanks for a finding could you please submit PR with a fix? > > Will see what I can do. Update: I haven't had time to look...

@AA-Turner Sorry for the direct ping again, but here's another hopefully obvious search fix in the vein of #11770

Attempted to add a unit test for this general case in #11950. I filed that as a seperate PR as I found some other minor bugs when working on that...