Xidorn Quan
Xidorn Quan
I don't think there is consensus that Rust is going to add this at all.
I was hoping that #10 can fix this as well, but unfortunately not. There are probably other places deep in the code which doesn't handle character boundary correctly.
This crate doesn't have a MSRV policy, and I would simply be tracing the latest stable version. I think the code of this crate should be stable enough that anyone...
That is to say, PR welcome :)
@bluebear94 Thanks for the request. It has been added in 0.1.10.
To be honest, I feel now that `CStr` is in `core`, maybe Rust should just add a new prefix form `c"xxx"` for static `CStr`.
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.
Not sure whether the reference implementation already takes the advantage of AVX, but it seems on my machine, it is much faster than this Rust implementation: ``` running 2 tests...
It seems the reference implementation doesn't take the advantage of AVX either. Even if compiled with `-march=nocona`, it is still much faster.
It seems whether AVX is enabled doesn't change things a lot. ``` $ cargo bench --features=simd test bench_argon2rs_i ... bench: 8,380,176 ns/iter (+/- 584,836) test bench_cargon_i ... bench: 7,336,689 ns/iter...