Daniel Lee

Results 106 comments of Daniel Lee

Force merging - @inlined's comments have all been addressed.

@stfsy This ia great callout - thanks for a very detailed writeup.

Hi @jacobsandlund - apologies for the issue you are seeing. Thank you for sharing your experiments. You are right - we shipped a bug. While we work on getting a...

@Schmale97 Do you mind sharing a quick example of your setup? I tried to reproduce your issue using the latest Firebase CLI (11.4.2) and Functions SDK (3.22.0) and running the...

@vamshiaruru-virgodesigns In that case, it is an expected behavior. Check out https://github.com/firebase/firebase-functions/issues/1084 why that's the case and what we are doing about it.

@tpodom Thanks for the pointer! I have a bug out for fixing that error at https://github.com/firebase/firebase-tools/pull/4926 However, I'm a bit worried that this only fixes the bug where function deploy...

@tpodom Thanks for following up. That gives me some closure on why things weren't working as I'd expect. Monorepo isn't something we failed to consider when developing in the CLI,...

@protyze Are you also using something like yarn/npm workspaces the way @tpodom described?

Issue is closed, but the fix will only be shipped in next CLI release. I'll try to have our team cut a release tomorrow. Thanks for your patience.

Sorry for the troubles @Ancinek @ky28059. I think I have a hunch on what's going on here and will see if I can a fix out. In the meantime, I...