Daniel Lee

Results 106 comments of Daniel Lee

@0xjei Thanks again for detailed bug report and your patience being on the bleeding edge. Will get back at the create issue soon,

@0xjei Sorry I didn't get back earlier. I reproduced a similar error to yours in my local setup: ``` import { onRequest } from "firebase-functions/v2/https"; export const v = onRequest({...

Great to hear! Thanks for being proactive and helping up squash many bugs! 🐛

Hey @morgs32. Thanks for taking the time to contribute. While reviewing the code, I noticed that both `DocumentSnapshot` and `QuerySnapshot` types already default to `DocumentData`: https://github.com/googleapis/nodejs-firestore/blob/28d645bd3e368abde592bfa2611de3378ca175a6/types/firestore.d.ts#L1121 https://github.com/googleapis/nodejs-firestore/blob/28d645bd3e368abde592bfa2611de3378ca175a6/types/firestore.d.ts#L1488 At least in...

@willhackett I'd love to understand what you mean by camlcased name functions better - can you elaborate why codebases doesn't fit your application? I'm planning to review https://github.com/firebase/firebase-tools/pull/4967 soon, but...

@gustavopch I think somewhere between the 2 extremes (1 codebase 100 functions vs 100 codebase 1 function) would help. For example, you might group function in a codebase by trigger...

@trex-quo Thanks for reporting the issue. Out of curiosity - is it possible that you may be running multiple deploys in parallel? I think another user reported the same error...

@trex-quo Thanks for a detailed reply. The Firebase CLI is tuned to deploy in batches of 40 functions at any given time, so I suspect issuing a single `firebase deploy`...

@trex-quo Thanks for the feedback. 50% success rate is terrible, and we should strive to do better. We'll work on tuning our parameters to deal w/ quota issues better. In...

@TraGicCode Thanks for raising the issue! I'm going to poke at some internal folks to see if I can get an answer to the duplicate log issue. On the other...