Smit Patel comments

Results 182 comments of


                                            Smit Patel

trafficstars

Restrict to 2 spymaster modes per game

I was something along the lines on the first idea @Pumpido75 had. A spymaster creates as room, decides a password and send it to the other spymaster. Everyone without the...

Global query filters raise a "An item with the same key has already been added" exception

@dapnet2018 - Which line in `GlobalQueryFilterTest` throws that exception? There is no clash in external/internal parameter names here so related EF issue is not the cause. Something else in second...

Global query filters raise a "An item with the same key has already been added" exception

This is the culprit for this exception: https://github.com/SteffenMangold/EntityFrameworkCore.Cacheable/blob/bbf8ee7e98d3fc8bbeedbef5609faaf9caaff2f4/EntityFrameworkCore.Cacheable/CustomQueryCompiler.cs#L188 since `CompileFunction` is being called twice on same queryContext, first call will add parameters based on query filter on query context. Then...

Odata 8 dynamic property received error: The given model does not contain the type 'System.Text.Json.JsonElement'

We cannot translate further operation on JSON if it is configured using value converter since we don't know what converter does. It is black box to us in terms of...

any() functions generates untranslatable query

``` .Where($it => $it.Specialities == null ? null : (bool?)$it.Specialities .Any() == (bool?)True) ``` Null check in this part is unnecessary. Comparing collection navigation to null has no meaning in...

IEnumerable and IReadOnlyCollection navigation properties throw System.Security.VerificationException

This issue is lacking enough information for us to effectively reproduce. Please post a runnable project/solution or complete code listing that demonstrates the behavior you are seeing.

[release/3.1] Move to Ubuntu 22.04

@bricelam - Sqlite functional tests are running into seg fault when switching ubuntu. (happens for 3.1/6.0 both but works fine in 7.0). Are you aware of some issues with older...

EntityBuilder: .OnDelete() is ignored if used after .IsRequired() and shadow property

The issue is still present. https://github.com/dotnet/efcore/blob/289e7a69b0c02f5569bbaf0ac353c21afde5e397/src/EFCore/Metadata/Internal/ForeignKey.cs#L687-L689 When changing required, the convention return new Fk to change deletebehavior to cascade but we don't pick up new FK and hence DeleteBehavior is...

Query: Pay your (technical) debt on time

Consider refactoring in cosmos similar to https://github.com/dotnet/efcore/pull/21181

Query: Pay your (technical) debt on time

#21700 causes slight regression and spike in memory usage just to compute hash code. Which leads into another rabbit hole that projection is mainly comprised of column expressions coming from...