Smit Patel comments

Results 189 comments of


                                            Smit Patel

trafficstars

Remove reference to EF-internal TpcTablesExpression

I am already working on this. Many edge cases but it will be done in 7.0

Improve documentation on how to write an EF Core provider

Releases to consider - LTS release - Current release (stable) - Current preview I think current preview would provide slightly lesser value. If I am writing a provider from scratch,...

Improve documentation on how to write an EF Core provider

The repo to host is less important. The sample should use package references rather than project references.

Document how to rewrite subquery equality when composite key

Also subquery.Contains

Translate queries where a row includes a collection to use arrays instead of being implemented through joins

Overall when utilizing arrays, what we need is to bypass whole pending collections thing since there is no collection in SQL anymore from join form. So when translating a collection...

Translate queries where a row includes a collection to use arrays instead of being implemented through joins

The only place where interaction would become complicated when "GetValue" doesn't have T as a mapped database type. i.e. DbDataReader. At that point, not only the GetValue injection part which...

Tag the commits that were inserted into a particular VS version

Is idea to create tag for VS releases or every VS insertion? Tagger.yaml is working to tag every insertion.

Tag the commits that were inserted into a particular VS version

We created pipeline which is running perfectly now. For 15.x/16.x we tagged very last release. Future patches are covered by automated pipeline itself.

Treat ToString as casting to string in the database

Also see https://github.com/dotnet/efcore/issues/14205 Convert a different ToString represent can give incorrect results in query.

Expose a non-generic DbSet to support operations with shared-type entity types

If you make `GetDbSetForClrType` generic on `TEntity` and invoke it like how you are doing to invoke `Call_DbSet_FromSqlRaw` you wouldn't need another method.