Smit Patel

Results 189 comments of Smit Patel
trafficstars

> Are we planning to support navigations from inside the JSON document outside and vice versa? If so, I didn't think this would be part of a 1st version -...

Add validation for not allowing JSON column for TPT/TPC

> private readonly IDictionary _materializationContextBindings can make these all dictionaries concrete Dictionary type? --- Refers to: src/EFCore.Relational/Query/RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.cs:133 in b40e728. [](commit_id = b40e7283c5f6382b7b5d062fc75d0f8019043d37, deletion_comment = False)

> var isTph = entityType.FindDiscriminatorProperty() != null; @AndriySvyryd can we just use mapping strategy method now? --- Refers to: src/EFCore.Relational/Metadata/Internal/RelationalModel.cs:364 in d0f43e3. [](commit_id = d0f43e38a4e320169e272647f08526532e9c8be9, deletion_comment = False)

> earlierClientProjectionCount = _clientProjections.Count; This is where we do process after lifting from single result subquery. Recompute the dedupe map here from this point to end point. --- Refers to:...

cc: @AndriySvyryd to review metadata/update pipeline changes.

Will be iterating over this PR. Wanted to get it out for review because I added docs for everything (and new exception points for ExecuteUpdate). Thanks for the review on...

Pending items, EF.Default & allowing joins & converting unsupported structure.

@ilmax - I read this thread for first time in detail. Thanks for looking into this and suggestion some ideas. Extending the conversation about design further, I believe it should...

Don't use custom types for join keys.