Konstantin Scheglov

Results 157 comments of Konstantin Scheglov

```console time dart /Users/scheglov/Source/Dart/sdk.git/sdk/pkg/analysis_server/test/test_all.dart ```

Replacing the marker file: https://dart-review.googlesource.com/c/sdk/+/254480

The problem is that function types are structural, they don't track provenance. Sometimes if is the same `FunctionType` instance, and so we could know that it is the same `ParameterElement`....

The Dart Analyzer team uses `package:test_reflective_loader` extensively for all our tests, and it is based on using mirrors. We found out early that vanilla `package:test` is not structured enough for...

Interesting. When I restart DAS, there is never any hint on `Foo(foo: null)`. When I switch to `Foo` declaration, and switch back there is always the hint on `Foo(foo: null)`....

Well, now I got it to the state when we always report the hint :-D

The main issue is that when looking from a legacy library, we consider `required this.foo` as optional, as requested in https://github.com/dart-lang/sdk/issues/43397. So, the linter does not exit on `!param.isOptional`. The...

A solution could be to update the lint rule so that it checks that the declaration of the parameter it required. ```dart if (param.declaration.isRequired || param.hasRequired) { continue; } ```