sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Published 20 hours ago • verified publisher icon dart-lang

Avoid false positives applying Google3 specific functionality to non-google3 specific bazel workspaces

Open jacob314 opened this issue 3 years ago • 2 comments

Related issue: https://github.com/dart-lang/sdk/issues/49544 The cherry pick was fine to unblock but I think the right solution to this is to stop treating non-g3 BAZEL workspaces as BAZEL workspaces as we don't really support that case anyway. To detect g3 bazel workspaces we should check for the magic dart/config/ide/flutter.json file like the Flutter IntellIJ support does. See https://github.com/flutter/flutter-intellij/blob/e6bb872cca41d5bcdaebc073c6c6882f3fc22633/flutter-idea/src/io/flutter/bazel/Workspace.java#L34 That should avoid false positives like this and keep our different tools consistent.

jacob314 avatar Aug 09 '22 22:08 jacob314

Fyi @scheglov

jacob314 avatar Aug 09 '22 22:08 jacob314

Start https://dart-review.googlesource.com/c/sdk/+/254343

scheglov avatar Aug 10 '22 00:08 scheglov

Replacing the marker file: https://dart-review.googlesource.com/c/sdk/+/254480

scheglov avatar Aug 10 '22 18:08 scheglov

https://dart-review.googlesource.com/c/sdk/+/255141

scheglov avatar Aug 15 '22 17:08 scheglov