Samuel Colvin

Results 1078 comments of Samuel Colvin

I'm getting the same error. look [here](https://github.com/samuelcolvin/xdelta3-python/blob/master/xdelta3/_xdelta3.c#L30) > output shouldn't be bigger than the original plus the delta, but give a little leeway Basically I assume that the size of...

see #3 @karamanolev, would be great if you could try that branch and check it's working for you. If ok, I'll merge and deploy an update.

Ok, but in real work #3 is better than the current value. Unless you want to submit a PR to dynamically allocate the output buffer size?

Agreed doubling would be easier. The problem is it will be slow(er) since the decode will have to retry until a suitable size is reached, what's worse this performance degradation...

ok, makes sense. Could you create a PR for doubling buffer size?

ok, I've updated #3 to double `output_alloc` until the buffer is big enough. @karamanolev does that look ok to you?

Makes lots of sense, then default to the current value. PR welcome.