arq icon indicating copy to clipboard operation
arq copied to clipboard

Bump redis version from <5 to <6

Open Wh1isper opened this issue 1 year ago • 5 comments

closes #458

Just tried to bump redis from <5 to <6, and CI tests passed.

redis 5 introduced some of incompatible API(aclose and close...) that made it difficult for users to change their code based on version 5, so I think bringing the version up to date it necessary.

Wh1isper avatar May 19 '24 15:05 Wh1isper

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.47%. Comparing base (94cd878) to head (af9b484). Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   96.27%   96.47%   +0.19%     
==========================================
  Files          11       11              
  Lines        1074     1078       +4     
  Branches      209      190      -19     
==========================================
+ Hits         1034     1040       +6     
  Misses         19       19              
+ Partials       21       19       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1315583...af9b484. Read the comment docs.

codecov[bot] avatar May 19 '24 15:05 codecov[bot]

May related with: https://github.com/samuelcolvin/arq/issues/418

Wh1isper avatar May 19 '24 15:05 Wh1isper

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   96.27%   96.01%   -0.27%     
==========================================
  Files          11       11              
  Lines        1074     1078       +4     
  Branches      209      190      -19     
==========================================
+ Hits         1034     1035       +1     
- Misses         19       21       +2     
- Partials       21       22       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f865a6...294939d. Read the comment docs.

codecov-commenter avatar Jul 30 '24 10:07 codecov-commenter

Is there any update on when this work might be considered for release?

dbrucknr avatar Aug 15 '24 15:08 dbrucknr

When are you planning to release with dependency updates?

vprud avatar Aug 23 '24 09:08 vprud

@chrisguidry @samuelcolvin 🙏 This is very important PR. Redis v5 is a significant blocker

RB387 avatar Aug 29 '24 09:08 RB387

Thanks so much.

samuelcolvin avatar Aug 29 '24 16:08 samuelcolvin

Sorry for the delay in getting back to this 🙏.

samuelcolvin avatar Aug 29 '24 16:08 samuelcolvin