roconnor-blockstream

Results 123 comments of roconnor-blockstream

I seem to have been mistaken / confused about relay policy. As I understand, it is the case that by default Bitcoin Core does relay transactions that spend to unassigned...

> Wallets probably shouldn't allow payments to undefined versions, Setting aside whether I agree with this or not, BIP173 currently reads: > but implementations MUST allow the use of any...

We can close this issue, but shouldn't there be some sort of "replaced-by: 350" metadata field?

I recommend going through and explicitly censoring the nonce stored in any CoinsView that represents the UTXO set.

Why don't we want to erase it from the mempool?

> It may be a good idea to output a preprocessor warning in this case, or actually remove the simulated 64x64->128 mul code because our tests will never exercise it.)...

I'm moving this out of draft stage. The coding is complete. There are a few tasks that remain. - [x] Double check that there is no signed integer overflow due...

I notice that your PR still keeps the `USE_*_WIDEMUL_*` in `util.h`. it still seems we cannot really move it out of `util.h` because it both selects between `INT128_STRUCT` and `INT128_NATIVE`,...

I've reviewed the changes in the association of `+` for signed int128 calculations to look for changes in overflow behavior. Signed int128 is only used in the `src/modinv64_impl.h` file. The...