roconnor-blockstream
roconnor-blockstream
Fixed in faed773f70b9500c78f166a1442031e05381a716.
For those using NixOS, I had to add protocol = "ssh-ng"; to my `nix.buildMachines` entry to remove the error that MathiasSven noted above.
See https://github.com/bitcoin/bitcoin/pull/27143 for the fix.
> Doing the sorting for the users eliminates a difficult to catch error and we'd need to sort anyways to be able to detect and alert the user that they...
99463184ca456853d5624e3830d439fd58ddd933 seems to add an extra blank line on line 2060 for no good reason.
`Page: 1 1` seems to now have `portraitPage begin` twice. Presumably this is an error
> Oh, good catch. This appears in `title.inc.ps` but shouldn't because the default.nix code now does it. Maybe I'm being too picky, but you patched the wrong commit. You should...
Are you familiar with `gitattributes`'s `export-subst`? [Bitcoin uses this](https://github.com/bitcoin/bitcoin/blob/master/.gitattributes) to insert a [define `GIT_COMMIT_ID`](https://github.com/bitcoin/bitcoin/blob/master/src/clientversion.cpp#L33) into this file. This method might make for a better way adding shortids to the (generated)...
Some further comments I have: BIP-32 defines a seed as a "byte sequence S of a chosen length (between 128 and 512 bits; 256 bits is advised) from a (P)RNG.",...
Since the master seed is thrown away in many implementations, it might make more sense to hash the master private key instead when generating an identifier in a deterministic manner.