elements icon indicating copy to clipboard operation
elements copied to clipboard

Published 20 hours ago • verified publisher icon ElementsProject

set nNonce to Null in CoinsView

Open apoelstra opened this issue 4 years ago • 6 comments

Alternative to #1006

Fixes #1008

apoelstra avatar Jun 08 '21 00:06 apoelstra

Lol, some of the new assertions are triggering in CI

apoelstra avatar Jun 29 '21 19:06 apoelstra

Sigh, so, the CCoinsView is a base class of two things -- the "UTXO set" which is saved to disk in the coinstate/ directory, where we want to erase the nonce, and the mempool tx db, where we do not want to erase the nonce (and there are existing assertions that prevent us from doing so).

apoelstra avatar Jul 02 '21 21:07 apoelstra

Any update on solving this?

stevenroose avatar Nov 25 '21 17:11 stevenroose

Why don't we want to erase it from the mempool?

roconnor-blockstream avatar Dec 01 '21 21:12 roconnor-blockstream

@stevenroose no update. I think it might be practically impossible.

@roconnor-blockstream because of tangled inheritance relationships between various mempool-like structures. If you do what you're suggesting you will get far away assertion failures in consensus code where they might be meaningful.

apoelstra avatar Dec 21 '21 15:12 apoelstra

I think we should just live with this bug.

apoelstra avatar Dec 21 '21 15:12 apoelstra