patak
patak
Could you explain a bit more here @brillout? And we should add a test case too. I thought not having the spa fallback was one of the reasons to have...
@brillout more than a test case, we need to understand why this is needed. I still don't get what are we fixing here.
@benmccann @matthewp @danielroe are you removing the spaFallbackMiddleware in SvelteKit, Astro, Nuxt using its function name? I would like to check if applying this fix in 3.1 is safe. If...
@danielroe to clarify, it isnt about using it, but if you are manually removing it by function name. If you are removing this middleware, then your app could break as...
Thanks for the feedback @matthewp, I see you are now using `appType: 'custom'` everywhere, no? https://github.com/withastro/astro/blob/ac03218247763e4782824e220a384fd20ae6d769/packages/astro/src/core/config.ts#L510 If that is the case, then you don't need to remove by hand this...
@bluwy SvelteKit is also using `appType: 'custom'`, no? I think we could merge this PR in 3.1 at the end
I also think that this isn't the best here. Maybe we should hash the input file name instead. It is an interesting optimization but feels to me that people should...
The possible issues I see are: - A user has several images with proper names (and two of them have the same content but are conceptually different). Maybe there is...
We decided today that there isn't a good use case yet to justify an option to avoid deduplication. Would you check if @timacdonald's PR is enough for your needs: -...
@AlonMiz @jpvincent @spacedawwwg @AlexandreBonaventure would you check if your use cases would be covered by the feature as implemented in: - #9938