patak

Results 373 comments of patak

@bluwy I'm going to merge this one so we can start testing it on main. If you have an idea for the tests, lets do that in another PR 👍🏼

@bgoscinski great findings! Let us know if you would like to work on a PR to fix this 👍🏼

I think something along the lines of 3 is the best, as even with two, people may add a link to a CSS by hand that we will miss with...

Great PR @sapphi-red. Leaving some references to previous related discussions. `createFilter` that we now expose through Vite and is used everywhere, uses `picomatch`. When Fran reported an [issue we had...

> > we even documented that only picomatch syntax is supported. > > It seems we weren't doing that. > > [vitejs.dev/guide/features.html#glob-import-caveats](https://vitejs.dev/guide/features.html#glob-import-caveats) [vitejs.dev/config/dep-optimization-options.html#optimizedeps-entries](https://vitejs.dev/config/dep-optimization-options.html#optimizedeps-entries) > > We could pass `braceExpansion: false`...

@qmhc we discussed this PR in today's team meeting and we think we can move forward with it. Before merging we should resolve the open discussions. We decided that the...

@poyoho @IanVS pinging you since you have been looking into this problem before. Related PRs: - https://github.com/vitejs/vite/pull/6301 - https://github.com/vitejs/vite/pull/9278 This PR from @sanyuan0704 looks good to me. Looking at your...

@IanVS @poyoho shouldnt we still apply this PR as a step in the right direction? We now have two diff orders if the preload is in HTML or it is...

@poyoho about this, > I am worried that it will affect users who used to run well with this bug. They should already be affected by this issue if that...

Adding this one to the 3.2 milestone to avoid potential issues. I think we should start the 3.2 beta sooner this time so we can ship this fix and others...