patak

If we ever do this, I think we could go with `envPrefix: false`. But I agree with @bluwy, and it is in line with what we discussed when we added...

@danielkov do you have an example of a real setup with this issue? What specific software is causing this problem that you don't control? I've added this PR to the...

@danielkov I wonder if a better approach would be to have a new `envAllowed` config option that lets you specify a safe list. So you can add `VERSION` and `APP_NAME`...

I think this may be a common enough use case that it could justify a straightforward option. I also like having the possibility of later letting users disable the feature...

Thanks for the PR @rtsao! The change looks good to me. About `jsxPure`, I think we could remove the option and force it to be always true for runtime `classic`....

Let's discuss this in the next meeting. I'm not sure if we would like to keep expanding on the `as` syntax given that there is a chance it will change....

@poyoho we decided to move forward with this feature in today's meeting 👍🏼 Would you rebase the PR once you have a chance? Let's merge it in 3.2

The difference with other places where we are using `stripLiteral`, is that we only use it after checking that there is a possible match (like checking for `import.meta.url` [here](https://github.com/vitejs/vite/blob/b2c0ee04d4db4a0ef5a084c50f49782c5f88587c/packages/vite/src/node/plugins/assetImportMetaUrl.ts#L28)). Maybe...

We discussed this PR in today's meeting @tony19, and we think that we should redefine the `define` feature as you did here to avoid replacing in strings. Regarding the implementation,...

> @patak-dev I tried using esbuild's `define` option, but only valid identifiers are allowed, so these defines would cause an esbuild error because the identifiers end with `.`: I think...