Oliver Gould

Results 207 comments of Oliver Gould

https://github.com/linkerd/linkerd2-proxy/pull/1931

Is there any way we could have caught this type of bug in CI?

We might also consider the [metadata-only API](https://github.com/kube-rs/kube/issues/1027) to be included on the `Client` type.

@rhysd I've only seen the failure once and it succeeded on retry (i.e. without making any changes to the branch) https://github.com/linkerd/linkerd2/runs/7535455694?check_suite_focus=true#step:4:23

It doesn't necessarily have to be done as a part of this PR, but I wonder if we could use a feature flag to control whether any of these dependencies...

@LucioFranco yeah, I'm not sure what the most usable approach is. The decision to use vs build a `protoc` is really up to the _application_ that is building a library...

While the [`proto2` spec](https://developers.google.com/protocol-buffers/docs/reference/proto2-spec) supports the `optional` keyword, the `optional` keyword is not part of the [`proto3` spec](https://developers.google.com/protocol-buffers/docs/reference/proto3-spec). All fields are optional in `proto3`.

Thanks for the helpful links! Oliver Gould < ***@***.*** > On Mon, Jun 07, 2021 at 12:32 AM, Danilo Bargen < ***@***.*** > wrote: > > > > @ olix0r...

`prost` uses [`heck`](https://github.com/withoutboats/heck)'s case conversion implementation, which does not support this.