linkerd2 icon indicating copy to clipboard operation
linkerd2 copied to clipboard

Published 20 hours ago • verified publisher icon linkerd

Fix wrongly passed prop to QueryParamProvider

Open MoSattler opened this issue 3 years ago • 1 comments

See use-query-params documentation.

fixes #9306

Signed-off-by: Mo Sattler [email protected]

MoSattler avatar Sep 22 '22 16:09 MoSattler

Nice @MoSattler I can verify it is functional in my environment.

image

jeremychase avatar Sep 22 '22 22:09 jeremychase

Is there any way we could have caught this type of bug in CI?

olix0r avatar Sep 23 '22 20:09 olix0r

@olix0r yes - with types or integration tests.

MoSattler avatar Sep 26 '22 14:09 MoSattler

I accidentally closed this PR. I wasn't able to reopen it, so I opened a new one here: #9518

MoSattler avatar Sep 29 '22 10:09 MoSattler