Oliver Gould

Results 207 comments of Oliver Gould

Thanks for the suggestion @jasonjckn. Do you have any thoughts on how you would expect this to be implemented? I think the best we can do is to just tear...

Here's an example where we do something similar in Conduit: https://github.com/runconduit/conduit/blob/13b33b6f3a257e8261cab599b2fc956b741636cb/proxy/src/transparency/server.rs#L187-L192

So, we're suggesting that `grpc::Request::from_http` steals `http::Request`'s extension map? SGTM.

possibly related: https://github.com/hyperium/hyper/pull/1594

@carllerche In Conduit, we have a _Destination_ service. The proxy has a client to this service, and we have code that, given such a client, interacts with the service. I...

@bbigras thanks for reporting this! If I understand correctly, `rx` should be dropped when the client disconnects such that subsequent calls to `tx.send` fails (though i'm not sure this is...

Ok. I think I see what's going on; and I think this should be fixed... Currently, the `rx` stream isn't dropped until the grpc server tries to _write data_ on...

@carllerche Here's what you said when we chatted about it: > basically, h2 needs to expose `is_reset` > and then tower-grpc needs to drop > it would check is_reset first...

It seems likely that we could instrument tower-router (or something like it) to dispatch requests to the appropriate service base don the URI prefix

@agend is `BobData` a protobuf `bytes` type? Perhaps we could use the [bytes](https://docs.rs/bytes/0.4.12/bytes/struct.Bytes.html) crate to represent this type to facilitate shared access to the underlying memory?